Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the AWS provider's default tags #49

Merged
merged 4 commits into from
Jun 2, 2021
Merged

Use the AWS provider's default tags #49

merged 4 commits into from
Jun 2, 2021

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented May 29, 2021 •
edited
Loading

🗣 Description

This pull request changes the Terraform module to make use of the default tags from the AWS provider instead of requiring a set of default tags to be passed in as an input variable.

💭 Motivation and context

This is simpler and cleaner, and is now the preferred mechanism for passing default tags.

🧪 Testing

I verified that terraform init -upgrade=true ran successfully with these changes.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

@jsf9k jsf9k added blocked This issue or pull request is awaiting the outcome of another issue or pull request breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use labels May 29, 2021
@jsf9k jsf9k self-assigned this May 29, 2021
@jsf9k jsf9k mentioned this pull request May 29, 2021
Open
3 tasks
@jsf9k jsf9k marked this pull request as ready for review June 1, 2021 14:41
@jsf9k jsf9k removed the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Jun 1, 2021
dav3r
dav3r approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🐙

mcdonnnj
mcdonnnj approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion to line up with changes in #47. Thanks for keeping an eye out for new features that help our workflows!

examples/basic_usage/variables.tf Outdated Show resolved Hide resolved
@jsf9k @mcdonnnj
Require AWS provider version to support default tags
7471af2 
Version 3.38.0 of the Terraform AWS provider is the first version to
support default tags.
https://www.hashicorp.com/blog/default-tags-in-the-terraform-aws-provider
@mcdonnnj mcdonnnj force-pushed the improvement/use-default-tags branch 3 times, most recently from 32cce04 to f35480d Compare June 2, 2021 20:35
jsf9k and others added 3 commits June 2, 2021 16:36
@jsf9k @mcdonnnj
Remove the tags variable, since default tags are passed in via the pr…
75c2d20 
…ovider

* Update the resources in main.tf accordingly
* Run terraform-docs to update README.md
@jsf9k @mcdonnnj
Update example code
3fb5ab6 
* Add tags variable that is then passed to the provider as the default
tags
* Run terraform-docs to update README.md
@jsf9k @mcdonnnj
End description with a period.
f35480d 
Co-authored-by: Nick M. <[email protected]>
@mcdonnnj mcdonnnj merged commit fb3f18c into develop Jun 2, 2021
@mcdonnnj mcdonnnj deleted the improvement/use-default-tags branch June 2, 2021 20:39
@mcdonnnj mcdonnnj mentioned this pull request Jun 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@hillaryj hillaryj Awaiting requested review from hillaryj

Assignees

@jsf9k jsf9k

Labels
breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @mcdonnnj