Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "header from" to CSV #105

Merged
merged 7 commits into from
Mar 24, 2023
Merged

Add "header from" to CSV #105

merged 7 commits into from
Mar 24, 2023

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Mar 20, 2023 •
edited
Loading

🗣 Description

This pull request modifies the Python code to include the "header from" domain in the CSV file.

💭 Motivation and context

Resolves cisagov/cyhy-system#80.

🧪 Testing

All automated tests pass. I also built a prerelease Docker image with these changes and tested it in production. I verified that the reports it generates are as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number python Pull requests that update Python code labels Mar 20, 2023
@jsf9k jsf9k self-assigned this Mar 20, 2023
jsf9k added 2 commits March 21, 2023 10:56
@jsf9k
Add an entry for the "Header From" column in the CSV file
4608890 
Also move the "Policy Applied" definition up to match the order in the
CSV file.
@jsf9k
Bump version from 1.5.0-rc.1 to 1.5.0-rc.2
37b1f07
@jsf9k jsf9k marked this pull request as ready for review March 23, 2023 13:48
@jsf9k jsf9k requested review from dav3r and mcdonnnj as code owners March 23, 2023 13:48
@jsf9k jsf9k requested a review from a team March 23, 2023 13:48
mcdonnnj
mcdonnnj approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough.

README.md Outdated Show resolved Hide resolved
dav3r
dav3r approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

jsf9k added a commit to cisagov/orchestrator that referenced this pull request Mar 23, 2023
@jsf9k
Use the latest version of the trustymail_reporter Docker image
7f81a70 
See cisagov/trustymail_reporter#105 for details.
@jsf9k jsf9k mentioned this pull request Mar 23, 2023
Merged
7 tasks
@jsf9k jsf9k merged commit a949b94 into develop Mar 24, 2023
@jsf9k jsf9k deleted the improvement/add-header-from-to-csv branch March 24, 2023 14:42
@jsf9k jsf9k requested a review from jasonodoom March 24, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

Assignees

@jsf9k jsf9k

Labels
breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use python Pull requests that update Python code version bump This issue or pull request increments the version number
Projects
BOD 18-01
Status: Done
CyHy System
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add header-from domain in Trustymail's dmarc_failures.csv
3 participants
@jsf9k @dav3r @mcdonnnj