Add VDP Hash to the Domain Results CSV #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a "VDP Hash" field to the domain CSV output. This field will contain the hash of the retrieved and parsed VDP per the cisagov/hash-http-content project. This field contains the hash on an HTTP OK response for the resolved URL and an empty string for anything else.
Switch to using zip() and casting to a dict to populate the results dictionary. This will allow existing definition to be the "source of truth" for the contents of the dictionary. This will reduce human error (or at least make it consistent) and improve maintainability.
mcdonnnj
added
the
improvement
jsf9k
approved these changes
Jul 22, 2021
dav3r
approved these changes
Jul 22, 2021
| # contents of result as values. This leverages the fact that the | ||
| # DomainResult NamedTuple is positionally aligned with the contents of | ||
| # the domain_csv_header list. | ||
| self.domain_results.append(dict(zip(self.domain_csv_header, result))) |
mcdonnnj
added a commit
to cisagov/ansible-role-vdp-scanner
that referenced
this pull request
Jul 23, 2021
This release includes maintenance updates and the functionality described in cisagov/vdp-scanner-docker#15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR adds the hash of a visited URL to the domain results output CSV.
💭 Motivation and context
This will allow for analysts to compare domains week-to-week to see if a change has occurred by comparing the respective hashes. This will close #12 .
🧪 Testing
I verified this worked locally and automatic tests pass.
✅ Pre-Approval Checklist
✅ Pre-Merge Checklist