Fix mypy Error and Correct Platforms in README
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves the following error seen in GitHub Actions runs: src/vdp_scanner.py:258: error: Argument 2 to "str" has incompatible type "Optional[str]"; expected "str" This error flags because the `encoding` property of a response object is not guaranteed to be set, but the str() function requires a string value for its second argument.
The platform shield in the README still used the default platforms from cisagov/skeleton-docker, but this Docker project only supports a subset of those platforms.
jsf9k
approved these changes
Sep 29, 2021
mcdonnnj
force-pushed
the
bug/small_fixes
branch
from
50ea59d to
ce71b15
Compare
mcdonnnj
force-pushed
the
bug/small_fixes
branch
from
ce71b15 to
844c6d1
Compare
|
Switched this to a release candidate because I will be stacking in multiple PRs for the final |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR fixes a
mypyerror and corrects an oversight in the project's README.💭 Motivation and context
The latest cisagov/action-apb triggered GitHub Actions run had the following error:
src/vdp_scanner.py:258: error: Argument 2 to "str" has incompatible type "Optional[str]"; expected "str"In the process of resolving that issue I noticed that the README did not have the correct platforms listed so I corrected them while I was working on the repo.
🧪 Testing
Automated tests pass. A local testing image ran as expected.
✅ Checklist
to reflect the changes in this PR.