Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Image Dependencies #25

Merged
merged 59 commits into from
Jun 22, 2022
Merged

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Oct 6, 2021

🗣 Description

This PR bumps the dependencies used for this Docker image.

💭 Motivation and context

Some of these packages are out-of-date and we were using an older Python image version.

🧪 Testing

Automated tests pass successfully. A local testing image was able to perform as expected.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added the dependencies Pull requests that update a dependency file label Oct 6, 2021
@mcdonnnj mcdonnnj self-assigned this Oct 6, 2021
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mcdonnnj mcdonnnj added the hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation label Oct 15, 2021
mcdonnnj and others added 11 commits February 23, 2022 20:11
Update pre-commit hooks using `pre-commit autoupdate`.
This comment explains that the configuration may have commented out
ignore directives that should be uncommented in downstream projects.
yamllint does not like it when you comment out pieces of dictionaries
in lists. Upcoming additions to the Dependabot configuration will run
afoul of this so we are updating the yamllint configuration.
…_yamllint_configurations

Add boilerplate for upcoming Dependabot configuration changes
Given the inconsistent behavior of underscores used within words for
style we should prefer asterisks now that these rules are available.
…configuration

Use new `markdownlint` rules for emphasis- and strong-styles
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2 to 3.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@mcdonnnj mcdonnnj force-pushed the maintenance/update_image_dependencies branch from 26397be to bcd493e Compare March 21, 2022 17:57
mcdonnnj and others added 10 commits March 28, 2022 16:19
Update pre-commit hooks using `pre-commit autoupdate`. The `ansible-lint` hook
is intentionally held back due to issues with upgrading to v6.
This adds commented out ignore directives for the following GitHub
Actions:

- action/cache
- action/checkout
- action/setup-python

These should be uncommented downstream to ensure that updates to these
dependencies are pushed from pull requests made in the skeleton.
…s/setup-python-3

Bump actions/setup-python from 2 to 3
…s/checkout-3

Bump actions/checkout from 2 to 3
Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2...v3)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…es_for_github_actions

Add Dependabot ignore directives
mcdonnnj and others added 20 commits June 13, 2022 10:34
…_versions

Update GitHub Action versions for this project
Update code to use the "docker compose" syntax vice "docker-compose"
Enable the new ignore directives for dependencies managed by
cisagov/skeleton-docker.
With a properly formatted Pipfile we have no reason to keep a
requirements.txt file so it is removed. The Pipfile has been updated to
better reflect what the Docker image should have installed. The version
of cisagov/hash-http-content is manually updated and all other
dependencies are updated with `pipenv lock`.
@mcdonnnj mcdonnnj force-pushed the maintenance/update_image_dependencies branch from bcd493e to e63a069 Compare June 18, 2022 01:24
@mcdonnnj mcdonnnj requested review from jsf9k and dav3r June 21, 2022 05:03
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one important question.

src/requirements.txt Show resolved Hide resolved
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⚡

@mcdonnnj mcdonnnj merged commit 7fd446f into develop Jun 22, 2022
@mcdonnnj mcdonnnj deleted the maintenance/update_image_dependencies branch June 22, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants