Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image dependencies #53

Merged
merged 3 commits into from
Sep 19, 2022
Merged

Update image dependencies #53

merged 3 commits into from
Sep 19, 2022

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request updates the dependencies for this image. This includes the apt packages and any Python packages in use.

💭 Motivation and context

The current configuration no long builds because the packages specified are no longer available. Per the GitHub Actions log:

#9 3.435 E: Version '102.0.5005.115-1~deb11u1' for 'chromium' was not found
#9 3.435 E: Version '102.0.5005.115-1~deb11u1' for 'chromium-common' was not found
#9 3.435 E: Version '1.1.34-4' for 'libxslt1-dev' was not found

🧪 Testing

Automated tests pass successfully. I invoked it locally with a list of domains and it ran within expectation.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj
Bump python from 3.10.5 to 3.10.7
3449828 
Also switch to hardcoding the Python version in image tags instead of
taking it as a build argument.
@mcdonnnj
Update apt package versions
bdb0e4d 
Update the versions of apt packages installed to the latest available.
@mcdonnnj
Update Python dependencies
5e22963 
This includes updating the version of Python configured in the Pipfile
to match the version of Python used in the Docker image.
@mcdonnnj mcdonnnj added the dependencies Pull requests that update a dependency file label Sep 19, 2022
@mcdonnnj mcdonnnj self-assigned this Sep 19, 2022
dav3r
dav3r approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@mcdonnnj mcdonnnj merged commit 8fa598e into improvement/project_updates Sep 19, 2022
@mcdonnnj mcdonnnj deleted the maintenance/update_image_dependencies branch September 19, 2022 18:41
@mcdonnnj mcdonnnj mentioned this pull request Sep 20, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy

Assignees

@mcdonnnj mcdonnnj

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r