Switch the base image from Debian Bullseye to Alpine LInux 3.16 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the operating system of the base image from Debian Bullseye to Alpine Linux 3.16. All dependencies and the `vdp_scanner.py` script are updated appropriately. The documentation and GitHub Actions workflow are also updated to support this change.
mcdonnnj
added
the
improvement
jsf9k
approved these changes
Sep 20, 2022
It's Linux, not LInux. Co-authored-by: dav3r <[email protected]>
mcdonnnj
force-pushed
the
improvement/switch_to_alpine_linux
branch
from
e5d825d to
c2f34b3
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request changes the base image from the
3.10.7-bullseyeand3.10.7-slim-bullseyetags to the3.10.7-alpine3.16tag. All necessary changes to support this change are made.💭 Motivation and context
Alpine Linux is especially suited for use in Docker images when possible due to its minimalist approach. Since everything this project needs is available for Alpine Linux 3.16 it made sense to update the image. The image size went from 748MiB to 457MiB so the space savings are significant.
🧪 Testing
Automated tests pass. I ran the new image locally and compared it to the output of the Debian-based image and there were no real differences (a single organization had a different hash but that could be the result of many things).
✅ Pre-approval checklist
to reflect the changes in this PR.
✅ Pre-merge checklist