Update Python dependencies #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the hard-coded Python package versions to environment values to improve maintainability.
Update the versions of the pip, pipenv, setuptools, and wheel packages defined in the Dockerfile.
Update the full Python version defined in the Pipfile and update all dependencies in the lock file by running `pipenv lock` in the `src/` directory.
jsf9k
approved these changes
Mar 3, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates the Python dependencies used by this project. This includes the versions of pip, pipenv, setuptools, and wheel explicitly defined in the
Dockerfileas well as the pipenv managed dependencies insrc/Pipfile.lock. It also updates the full version of Python in thePipfileto match the version used in the Docker configuration. Lastly the Python package versions stored in theDockerfileare broken out into environment variables to improve maintainability.💭 Motivation and context
Python dependencies should be kept up-to-date as possible.
🧪 Testing
Automated tests pass. I ran the image locally and it was able to scan websites within expectations.
✅ Pre-approval checklist