Update image configuration and fix CSV processing #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These represent the current versions available for Alpine Linux 3.18. The tag for the `python` Docker image was also updated to reflect the change in system Python version being installed.
The Pipfile should have the same Python version as that specified in the Dockerfile. Dependencies were updated with `pipenv lock` as well.
Bump pip from 23.1.2 to 24.0 Bump pipenv from 2023.10.20 to 2023.12.1 Bump setuptools from 67.7.2 to 69.2.0 Bump wheel from 0.40.0 to 0.43.0
In cisagov/dotgov-data#114 the headers for the `current-federal.csv` file were changed. This updates the script used in this Docker configuration to use the updated header field values.
mcdonnnj
added
bug
mcdonnnj
requested review from
dav3r,
felddy,
jasonodoom and
jsf9k
as code owners
jsf9k
reviewed
Apr 8, 2024
I'd rather keep this as "necessary changes for the PR's purpose" as possible in line with our bullet regarding scope creep. |
jsf9k
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request does the following:
Dockerfile.Dockerfile.Pipfileto reflect changes in Python version.Pipfileto update any dependencies inPipfile.lock.vdp_scanner.pyscript to account for CSV header format changes.💭 Motivation and context
The Alpine Linux package changes are required for the image to build successfully and since I would need to re-lock the
Pipfileafter updating it to match Python versions used in theDockerfileit made since to update all of the dependencies. There were some capitalization changes incurrent-federal.csvthat breakvdp_scanner.pyso that needed to be fixed.🧪 Testing
Automated tests pass. The image builds successfully. I used this branch's image in production to process this week's domain scan reports.
✅ Pre-approval checklist
✅ Post-merge checklist