Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(extra-natives-five): add DrawCorona native #3113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(extra-natives-five): add DrawCorona native #3113

wants to merge 1 commit into from
+104 −0

Conversation

DaniGP17
Copy link
Contributor

Goal of this PR

Added native DRAW_CORONA to render more advanced light effects, like volumetric lights.

image

How is this PR achieving the goal

Creating the CCoronas structure that contains the list of coronas, and a method to add new ones.
The patterns have been taken from thorium-cfx@26f7e2d and the CF_NO_RENDER_UNDERGROUND flag from https://github.com/alexguirre/Spotlight/blob/master/Source/Core/Memory/GameStructs.cs#L296

This PR applies to the following area(s)

FiveM, Natives

Successfully tested on

Game builds: 3095, 3407

Platforms: Windows, Linux

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Jan 30, 2025
Nobelium-cfx
Nobelium-cfx approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@Nobelium-cfx Nobelium-cfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the contribution!

Just a few minor typos and nits. PTAL.

code/components/extra-natives-five/src/VfxNatives.cpp Outdated Show resolved Hide resolved
code/components/extra-natives-five/src/VfxNatives.cpp Outdated Show resolved Hide resolved
code/components/extra-natives-five/src/VfxNatives.cpp Show resolved Hide resolved
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Feb 4, 2025
@DaniGP17
Copy link
Contributor Author

DaniGP17 commented Feb 4, 2025

Should be good now

@github-actions github-actions bot added invalid Requires changes before it's considered valid and can be (re)triaged and removed triage Needs a preliminary assessment to determine the urgency and required action labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacevx spacevx spacevx left review comments

@Nobelium-cfx Nobelium-cfx Nobelium-cfx approved these changes

Assignees
No one assigned
Labels
invalid Requires changes before it's considered valid and can be (re)triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaniGP17 @spacevx @Nobelium-cfx