Fix options for data sent to UI #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow screenshot_basic:requestScreenshot to actually work correctly. The original code would not receive the options, and would cause the server export "requestClientScreenshot" to not send any requests back to the server when fileName is nil. Since the readme states that an undefined fileName should return a data uri this is the incorrect behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow screenshot_basic:requestScreenshot to actually work correctly. The original code would not receive the options, and would cause the server export "requestClientScreenshot" to not send any requests back to the server when fileName is nil. Since the readme states that an undefined fileName should return a data uri this is the incorrect behavior