-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: uuid v4 validation matcher #1248
Merged
bbortt
merged 1 commit into
citrusframework:main
from
phos-web:feat/TAT-1196-uuid-validation
Nov 7, 2024
Merged
feat: uuid v4 validation matcher #1248
bbortt
merged 1 commit into
citrusframework:main
from
phos-web:feat/TAT-1196-uuid-validation
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbortt
requested changes
Nov 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for your contribution. I've only left two small remarks.
...-base/src/main/java/org/citrusframework/validation/matcher/core/UuidV4ValidationMatcher.java
Outdated
Show resolved
Hide resolved
...e/src/test/java/org/citrusframework/validation/matcher/core/UuidV4ValidationMatcherTest.java
Outdated
Show resolved
Hide resolved
bbortt
added
Type: Feature
Prio: Medium
good first issue
A good point to start from for new contributrs
State: Review
If pull-request has been opened an is ready/in review
labels
Nov 2, 2024
phos-web
force-pushed
the
feat/TAT-1196-uuid-validation
branch
from
November 6, 2024 09:22
dde5ee1
to
a9f25fc
Compare
bbortt
requested changes
Nov 6, 2024
...e/src/test/java/org/citrusframework/validation/matcher/core/UuidV4ValidationMatcherTest.java
Show resolved
Hide resolved
...se/src/main/java/org/citrusframework/validation/matcher/DefaultValidationMatcherLibrary.java
Outdated
Show resolved
Hide resolved
phos-web
force-pushed
the
feat/TAT-1196-uuid-validation
branch
from
November 6, 2024 13:10
a9f25fc
to
48488de
Compare
bbortt
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
bbortt
added a commit
to postfinance/citrus
that referenced
this pull request
Nov 10, 2024
in addition to citrusframework#1248.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
A good point to start from for new contributrs
Prio: Medium
State: Review
If pull-request has been opened an is ready/in review
Type: Feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added validation matcher which checks if value is a UUID v4