Fail more gracefully when upgrading on PHP5.x #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
Update function names to be about backdrop
|
The previous failure w as a style error that appears to have snuck into Will do a separate PR for the style issues in master. |
totten
added a commit
to totten/civicrm-buildkit
that referenced
this pull request
Aug 21, 2019
Before ------ On Backdrop builds, `drush` cannot be used - because the drush-backdrop plugin is missing. After ----- On Backdrop builds, `drush` can be used - because the plugin is present. Comments -------- This has come up a few ways - e.g. * Test/demo sites don't have a test/demo user - https://lab.civicrm.org/infra/ops/issues/906 * When QA'ing patches for civicrm-backdrop's copy of `civicrm.drush.inc` - e.g. civicrm/civicrm-backdrop#98
|
Tested locally and confirmed that web UI and CLI both fail more gracefully with this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to be a port of @totten's drupal PR here https://github.com/civicrm/civicrm-drupal/pull/583/files