Merge pull request #14621 from pradpnayak/CleanUps

Use api to create activity and removed hardcoded status id
civicrm · Sep 4, 2019 · 8437566 · 8437566
2 parents 1f5d2c3 + c1aac8a
commit 8437566
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/CRM/Financial/BAO/ExportFormat.php b/CRM/Financial/BAO/ExportFormat.php
@@ -209,11 +209,10 @@ public static function createActivityExport($batchIds, $fileName) {
 
     // create activity.
     $subject .= ' ' . ts('Batch') . '[' . $values['title'] . ']';
-    $activityTypes = CRM_Core_PseudoConstant::activityType(TRUE, FALSE, FALSE, 'name');
     $activityParams = [
-      'activity_type_id' => array_search('Export Accounting Batch', $activityTypes),
+      'activity_type_id' => 'Export Accounting Batch',
       'subject' => $subject,
-      'status_id' => 2,
+      'status_id' => 'Completed',
       'activity_date_time' => date('YmdHis'),
       'source_contact_id' => $session->get('userID'),
       'source_record_id' => $values['id'],
@@ -226,8 +225,7 @@ public static function createActivityExport($batchIds, $fileName) {
         'upload_date' => date('YmdHis'),
       ],
     ];
-
-    CRM_Activity_BAO_Activity::create($activityParams);
+    civicrm_api3('Activity', 'create', $activityParams);
   }
 
   /**