-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minimum php version to 5.5 #11453
Conversation
@colemanw this is designed to fail right now isn't it? |
Ah, yes of course it would. We have a little bit of a chicken-and-egg problem with this one @mlutfy |
yeh that sounds about right ping @totten to this discussion as well |
Actually, rereading the blog post, I think we shouldn't merge this until 4.7.32 - which should be released in March. |
test this please |
4.7.32 is the current 'master' |
@mlutfy is this ok to merge now? Tests are passing, does that mean php has been upgraded on the CI server? |
@colemanw CI servers are running PHP 5.4, and tests do not have anything requiring 5.5, I think? In any case, +1 on merging this, and then we can upgrade the CI servers to PHP 5.5. |
@mlutfy chicken and egg - this PR will cause the upgrade tests to fail if the CI server is not running 5.5, since the upgrade will bomb. I'm really not sure why there is a green light on this PR currently but it wasn't there before. I think it's safest to upgrade the CI servers prior to merge. Will you do that? |
@civicrm-builder retest this please. |
Overview
Bumping up the minimum version to follow the schedule laid out in https://civicrm.org/blog/totten/end-of-zombies-php-53-and-54
Technical Notes
This PR will fail testing until php has been upgraded on the CI server running the tests.
We should upgrade the server and merge this PR in time for the 4.7.32 release in March.