Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum php version to 5.5 #11453

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Update minimum php version to 5.5 #11453

merged 1 commit into from
Mar 6, 2018

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Dec 22, 2017

Overview

Bumping up the minimum version to follow the schedule laid out in https://civicrm.org/blog/totten/end-of-zombies-php-53-and-54

Technical Notes

This PR will fail testing until php has been upgraded on the CI server running the tests.

We should upgrade the server and merge this PR in time for the 4.7.32 release in March.

@seamuslee001
Copy link
Contributor

@colemanw this is designed to fail right now isn't it?

@colemanw
Copy link
Member Author

Ah, yes of course it would. We have a little bit of a chicken-and-egg problem with this one @mlutfy
We need to update the CI in order to merge this in, but we want to merge it in soon so it gets into 4.7.31.
I guess the thing to do is to update the CI and merge this immediately before creating the 4.7.31-rc.

@seamuslee001
Copy link
Contributor

yeh that sounds about right ping @totten to this discussion as well

@colemanw
Copy link
Member Author

colemanw commented Dec 22, 2017

Actually, rereading the blog post, I think we shouldn't merge this until 4.7.32 - which should be released in March.

@colemanw colemanw added the needs-work-not-review-ready Submitter required to take action, will be closed after 1-2 weeks in this state label Dec 22, 2017
@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

4.7.32 is the current 'master'

@colemanw
Copy link
Member Author

@mlutfy is this ok to merge now? Tests are passing, does that mean php has been upgraded on the CI server?

@mlutfy
Copy link
Member

mlutfy commented Feb 21, 2018

@colemanw CI servers are running PHP 5.4, and tests do not have anything requiring 5.5, I think?

In any case, +1 on merging this, and then we can upgrade the CI servers to PHP 5.5.

@colemanw
Copy link
Member Author

@mlutfy chicken and egg - this PR will cause the upgrade tests to fail if the CI server is not running 5.5, since the upgrade will bomb. I'm really not sure why there is a green light on this PR currently but it wasn't there before. I think it's safest to upgrade the CI servers prior to merge. Will you do that?

@colemanw colemanw added merge on pass and removed needs-work-not-review-ready Submitter required to take action, will be closed after 1-2 weeks in this state labels Mar 5, 2018
@colemanw
Copy link
Member Author

colemanw commented Mar 5, 2018

@civicrm-builder retest this please.

@mlutfy mlutfy added this to the 4.7.32 milestone Mar 6, 2018
@mlutfy mlutfy merged commit e22d01c into civicrm:master Mar 6, 2018
@eileenmcnaughton eileenmcnaughton deleted the php55 branch March 6, 2018 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants