CRM-21708: Fixed page structure by adding/removing classes #11585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradpnayak
reviewed
Jan 25, 2018
| @@ -51,7 +51,7 @@ | |||
| </tr> | |||
| <tr> | |||
| <td> | |||
| <div id="crm-submit-buttons"> | |||
| <div class="crm-submit-buttons"> | |||
There was a problem hiding this comment.
Why some buttons have class and id and some only class?
There was a problem hiding this comment.
@pradpnayak that's structuring issue. We are trying to identify and fix any such bugs.
There was a problem hiding this comment.
@pradpnayak no reply from your end, should we move ahead and merge it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes class structure for different pages to make it look better
Screenshots
Currently This PR is not having much of visual difference to see but, in future this can be crucial when given attention to common styling. (hence no screenshot)