[NFC] CRM-21739 Test improvements for mailing getRecipients #11642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins Re test this please |
|
@JKingsnorth it's passing is it still wip? |
|
Yes indeed, I have a whole suite of additional tests to add. |
JKingsnorth
changed the title
|
@eileenmcnaughton @seamuslee001 @monishdeb I've done all I can on tests for this for now. Better than nothing I hope! This should help prevent future regressions in the functionality to include/exclude mailing groups in email mailings. There are still some significant gaps in the tests, but this is a starting point at least. Tests are passing locally, so if someone could review the test logic then it would be great to get this merged. |
JKingsnorth
changed the title
|
Great work @JKingsnorth :) Will test and merge this PR shortly 👍 |
|
Reviewed the code and it covers the scenario well. Also the test build passes now, hence merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for getRecipients method to ensure that mailing groups included/excluded from email mailings are included in the recipient list for a mailing.