CRM-21778 - Contact image uploaded from drupal webform don't render o…

[jitendrapurohit]

…n summary page

Overview

Fix display of contact image which is uploaded from a webform.

Before

Contact image uploaded from drupal webform doesn't render on the summary page.

After

Image loads correctly without any notice errors.

Technical Details

Image uploaded from a Drupal webform resides in its own webform directory placed at sites/default/files/webform. This PR extends getImageURL() to look for exact url image if it is not found in our customFileUploadDir path.

---

• CRM-21778: Contact image uploaded from drupal webform don't render on summary page

[colemanw]

@monishdeb could you take a look at that? This function was your change I believe, in CRM-19501. What was the reason for restricting the location to that one directory?

[monishdeb]

@colemanw as I recall, that change, to pick that directory here was inspired by how image preview page works, which uses the same location to display or download file see here as because, all the file uploads stores at customFileUploadDir dir.

CRM-19501 was an improvement to use customFileUploadDir to get absolute file path and using that, retrieves the thumbnail coordinates of the uploaded image.

As per this patch is concerened, it makes the getImageURL() flexible enough to decide imageURL based on photo argument present in image url or not, which is correct though as I tested though different scenario in Civi. And also ensured that there is no sideffect due to this change. Hence merging.