Fix more entities to support custom fields (via api) #11688
Conversation
|
@eileenmcnaughton Any reason why ContributionRecur entity is not included here? Just wondered as I'm currently working on some payment stuff that requires custom fields on that entity. |
|
test this please |
eileenmcnaughton
force-pushed
the
custom
branch
2 times, most recently
from
15f3eb9 to
9152b56
Compare
|
@mattwire it is included because it was previously tested & working. This patch moves us to marking the ones that DON'T work |
eileenmcnaughton
force-pushed
the
custom
branch
2 times, most recently
from
9fe82c3 to
5136291
Compare
eileenmcnaughton
force-pushed
the
custom
branch
from
5136291 to
a25b46e
Compare
|
@colemanw another one of these - switches from a list of ones that DO work for custom data to a list of ones that don't |
|
@eileenmcnaughton so this list applies only to the unit test? |
|
@colemanw so after merging the entities in this list https://github.com/civicrm/civicrm-core/pull/11688/files#diff-bddbee60cb233dfdfeeb835d1614fcdeR374 are the ones that still don't work (& yes that list applies only to that test, not other tests) |
|
I'll merge this, but I"m curious about the implications to extension-defined entities. Will they get custom data by default? |
|
I think as long as they use basic get & pass through the entity they will |
Overview
This moves us closer to the goal of being able to define custom data on 'any entity'. It takes us from a limited list of ones that work to a longer list of ones that still don't work
Before
Small list of entities that can have custom data added.
After
Most entities can have custom data added
Technical Details
I would really like to be able to say 'custom data works on any entity in 5.0.0.0' when it is released in April. However, per the list in the test there are still a few that don't work (about 10-15% I think).
Comments
Am also adding a fix to GroupOrganization so it supports 'update with id' as this BAO needed some tweaks