Move towards standardising website.create function.

[eileenmcnaughton]

Overview

Standardisation of website create function

Before

Website create function is highly specific & rather alarmingly includes deletion within create

After

The customised function is renamed to process & the places in the code identified to call it are changed to call the 'process' function.

Technical Details

To prevent hard-breakage a 'create' function still exists and if the calling code appears to be calling the 'old' create then process will be called. This is determined by the passed params as the old function took an array of website arrays & had 2 optional params. the api WILL pass an $ids array so we check if param 2 is empty or an array while deciding.

Comments

We've seen a string of fixes & regressions like these #11683 #11634 #11428 and I think we need to
a) get a sensible BAO / api working
b) determine if we agree that website type is optional & need not be unique - there could be flow on impacts on searches , reports & joins if they are not unique
c) handle what needs to be done with form input in a form function & remove the BAO process as & when we can

@yashodha @agh1 you have both been involved in previous patches around attempts to fix #11683 & may have opinions

[eileenmcnaughton]

@colemanw a way to phase out create functions that also delete (can use the same approach on UFJoin)

[colemanw]

For point B, is there any precedent already for enforcing them to be unique?

[eileenmcnaughton]

@colemanw well the UI has enforced it (one way or another) for a long time - & people keep logging issues to change that. I don't know that the api has enforced it though

[eileenmcnaughton]

@colemanw note that this PR is separate to us resolving b - it should be merged either way as it solves the 'WTF would you write a create function with a delete it in' issue

[colemanw]

What about being more specific instead of checking $skipDelete for truthyness check if it is not null?

[eileenmcnaughton]

on the off possibility someone was passing in FALSE in the past? I guess I can - although I changed the only places in core & suspect that it's not being called from outside of core

[eileenmcnaughton]

OK - done

[colemanw]

Ok, merging. This is an internal function with api test coverage, so if the tests pass, it works.