Fix relationshipType, paymentProcessorType, Note & jobLog apis to support custom data #11721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
changed the title
eileenmcnaughton
force-pushed
the
website
branch
3 times, most recently
from
e0e4eb4 to
4fab8e2
Compare
eileenmcnaughton
force-pushed
the
website
branch
from
4fab8e2 to
da2dec3
Compare
|
test this please |
|
@colemanw here are a few more api standardisations towards 'custom data on any' |
|
This looks good and is consistent with other cleanups. Tests are passing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix relationshipType, paymentProcessorType & jobLog apis to support custom data
Before
Apis are non-std
After
Apis are standardised
Technical Details