CRM-21819 - Do not load 'Submit Credit Card Contribution' button if only pseudo-manual processor exists #11757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a recent regression where the 'submit credit card' shows back office when it should not
Before
Submit credit card shows regardless of whether it works
After
Submit credit card only shows if it should
Technical Details
getPaymentProcessors has started to return the manual pay later processor so it evaluates to not empty when only the manual pay later processor exists. We need to change it so it only shows true if a true processor exists (a true processor being on that has an entry in civicrm_payment_processor table - it could be an instance of the Manual processor if people want to do offline recurring for manual payments)
Comments
Replaces #11743