CRM-21756: Freeze total amount field on Edit Contribution if related to Membership or Event registration

[monishdeb]

Overview

Currently, when we change the total amount of membership payment, it doesn't update the corresponding line-item data. Instead, we can recreate the membership payment or we either use Lineitem editor.

Before

Total amount field is editable and on change leads to outdated line-item entry.

After

Total amount field is frozen and there is help text beside this field that provides instruction to perform the same task either by recreating the membership or using Lineitem Editor.

---

• CRM-21756: Editing Contribution (total_amount) does -not- update LineItem (line_total)

[monishdeb]

@eileenmcnaughton will you help me to change the help text more appropriate?

[kcristiano]

(CiviCRM Review Template WORD-1.1)

(r-explain) Pass
(r-test) Pass
(r-code) Pass
(r-doc) Pass
(r-maint) Pass
(r-run) Pass - I was able to replicate the problem without the patch.   With the patch you can no longer edit teh total amount
(r-user) Pass
(r-tech) Pass

The message

You are not allowed to change the total amount as it will lead to incorrect line item entries. You can either delete or recreate or install Line Item Editor.

My only issue is that I cannot install the Line Item editor from the CiviCRM Extension Page If we are promoting the extension, I think it should be available for users to install from inside CiviCRM.

As far as my attempt on the language:

You cannot change the total amount as it will lead to incorrect records in the database. If you need to edit the Total Amount you can either delete and recreate the transaction or install Line Item Editor.

[eileenmcnaughton]

test this please

[eileenmcnaughton]

I tested this & looked at the code as @kcristiano had & am happy to merge it. I agree with Kevin's points ie. 1) his wording is slightly better - that will be easy to merge as a follow up & 2) @monishdeb @JoeMurray can I get you to commit to submitting lineitemedit for review. I am happy to submit a review as I've already been looking at it & the code looks solid to me & it seems a clear improvement installing it

[tannerm]

This commit caused an issue with a client site where they are no longer able to update the Financial Type of contributions associated with Membership or Participant. Previously there was a conditional isset($this->_values['tax_amount']) that failed thus allowing them to edit the Financial Type since the tax_amount was set to NULL.

Can you explain a little more why the tax_amount conditional was removed? Thanks!

[eileenmcnaughton]

I think because it was not actually accurately updating all the related financial entities - have you tried the line item editor extension?

[tannerm]

Oh! I have not. I'll look into that... thanks for the quick reply!

[tannerm]

@eileenmcnaughton finally getting back around to this and that extension worked perfectly. Thanks!

[eileenmcnaughton]

@tannerm great (fyi @JoeMurray @monishdeb )

[JoeMurray]

@Edzelopez could you ensure that the Line Item Edit extension is published and up to date and available for auto-download? Thanks.

[mfb]

We need to be able to edit the contribution financial type, but it looks like if we use the Line Item Edit extension, that lets us modify the line item, but the financial type of its parent contribution is not updated.

[eileenmcnaughton]

@monishdeb do you think you can update line item editor to permit editing financial type on the contribution at the same time ?

[JoeMurray]

We could. Please create an issue on its repo and assign to @Monish.

[JoeMurray]

@mfb would it be okay if just let people choose whatever they want for contrib FT? It's irrelevant to accounting entries, though many orgs just use reports where contrib FT has historically been key.

[eileenmcnaughton]

thanks @JoeMurray

[mfb]

Yes, reports is why we need to be able to set it. I would say civi admins should be able to set it to whatever they want - either Civi core should let them do this, or the extension could do it. My 2 cents is that Civi core could make this editable, but I leave this up to folks who have spent more time looking at the related code :)

[mfb]

Created an issue on the extension: JMAConsulting/biz.jmaconsulting.lineitemedit#32

[JoeMurray]

Thanks @mfb