Revert "CRM-8140: Not possible to select fields for export when using Custom Searches"

[eileenmcnaughton]

Overview

This reverts commit ce40afa.

My testing showed that commit enabled the selection of fields for export from a custom search, but the exported rows included ALL rows in the DB. The 'where' from the custom search was not applied.

Before

Choosing export contacts takes user to a screen where they can choose columns to export or use defaults. If they choose the columns then the resulting export is NOT limited to the contacts from the search query

(I have been using include exclude search. The default data set has groups of 'Newsletter subscribers and Summer programme volunteers that provide a good baseline)

After

Choosing export as an action results in an immediate export of the default rows.

Technical Details

@seamuslee001 don't suppose you'd be able to test the latest rc for this on an ACL'd user. My suspicion is that ACLs are still applied but I believe we should confirm

Comments

I believe exporting too many contacts is much more dangerous than not having the option to choose the fields to export (a long-missing feature)

@colemanw @monishdeb this reverts #11458 which you worked on. I believe revert is the best option for the rc & a full (tested) fix is the next step

---

• CRM-8140: Not possible to select fields for export when using Custom Searches

[colemanw]

Agree we should revert this until a fix is found for the bug.