Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-21244 Update documetnation so it makes sense when setting is disabled #11914

Merged
merged 1 commit into from
Apr 1, 2018
Merged

CRM-21244 Update documetnation so it makes sense when setting is disabled #11914

merged 1 commit into from
Apr 1, 2018

Conversation

seamuslee001
Copy link
Contributor

@seamuslee001 seamuslee001 commented Mar 31, 2018 •
edited by civicrm-builder
Loading

Overview

This updates the help text so that it makes sense when the allow logged in user emails is disabled

Before

Confusing help text

After

Less confusing help text

ping @Stoob @mattwire What do you think about these help text changes

@seamuslee001
Copy link
Contributor Author

Jenkins re test this please

@eileenmcnaughton
Copy link
Contributor

I'm going to merge this since it is an improvement & being that it is against the rc we should get it merged quickly. As a help text only change it is low risk. However, I ask @Stoob & @mattwire to please test the rc & check that text & any follow suggestions can be in a follow up pr against master

@eileenmcnaughton eileenmcnaughton merged commit 0082105 into civicrm:5.0 Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seamuslee001 @eileenmcnaughton @civicrm-builder