Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.3 - Handle 'Check for Matching Contact(s)' button with ajax #12550

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

colemanw
Copy link
Member

Overview

Fixes the 'Check for Matching Contact(s)' button when ajax deduping is enabled

Before

The button would still work if ajax deduping was disabled in system prefs, but didn't work if ajax mode is enabled.

After

The button works either way. If ajax mode is enabled, clicking the button will use ajax. Otherwise it does it the old way.

@civibot
Copy link

civibot bot commented Jul 24, 2018

(Standard links)

@seamuslee001
Copy link
Contributor

As per my comment here #12547 (comment) i tested this on a 5.3 install and it passed ping @eileenmcnaughton @monishdeb @totten

@colemanw
Copy link
Member Author

FYI Unit tests don't cover .tpl files, so the pending PR tests are irrelevant.

@colemanw
Copy link
Member Author

colemanw commented Jul 24, 2018

Whoops, I just had a little git mistake and when updating this PR I accidentally pushed to the civicrm repo instead of my branch. So commit 116f2b4 is now in the 5.3 branch. But this PR still needs to be merged to get the other commit.

@colemanw colemanw reopened this Jul 24, 2018
@eileenmcnaughton eileenmcnaughton merged commit be926fa into civicrm:5.3 Jul 24, 2018
@eileenmcnaughton eileenmcnaughton deleted the 5.3 branch July 24, 2018 19:34
@colemanw colemanw restored the 5.3 branch July 24, 2018 22:00
@colemanw colemanw deleted the 5.3 branch January 31, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants