Activity display, switch to more performance getActivities function (from deprecatedGetActivities)

[eileenmcnaughton]

Overview

Minor performance improvement on activity tab. Improve code readability

Before

Note that the indent on the assigned fields increases with each contact added in a little diagnonal line

After

Most unchanged but a minor alignment improvement on assigned
(http://www.cockos.com/licecap/), SilentCast) where appropriate._

Technical Details

There are details here #12557

Comments

@lcdservices maybe you would test this on sites that use cases for me?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[lcdservices]

@eileenmcnaughton I couldn't actually reproduce the issue. Without this patch, the list of assignees was flush left. However, there was no negative impact from the PR -- they remained flush left. I tested both activities and case activities and the list opened pretty quickly and displayed properly.

[eileenmcnaughton]

@lcdservices the visibility change was a side effect I noticed - but my main motivation was the speed issue - although it's much more prominent on getcount than on getactivities as getcount will retrieve all the activities on the contact's record

I note that our performance issues on bad queries are rather magnified due to us having a larger DB than most

[eileenmcnaughton]

@seamuslee001 @davejenx also keen to have you test this for performance & acl user impact.

[seamuslee001]

@eileenmcnaughton i'll see what i can do in the next day or so on both PRs just got a bit on testing wise

[eileenmcnaughton]

Thanks @seamuslee001

[seamuslee001]

I have tested this on our dev site using an ACLed user. I haven't seen any obvious signs of performance degradation and the activities still output correctly. This is good to merge

[seamuslee001]

Merging

[eileenmcnaughton]

Thanks @seamuslee001