Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/mail#21 trim test emails #12599

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Conversation

lcdservices
Copy link
Contributor

Overview

https://lab.civicrm.org/dev/mail/issues/21
Sending a test email to multiple recipients may result in duplicate contacts being created.

Before

If sending a test email to multiple email addresses that are separated by a comma and space, the second+ email may result in a duplicate contact being created.

After

No duplicate is created.

Technical Details

The comma-separated list of email addresses needed to be trimmed in order to ensure a valid match with existing contacts.

@civibot
Copy link

civibot bot commented Jul 30, 2018

(Standard links)

Copy link
Contributor

@jitendrapurohit jitendrapurohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that it works as expected and avoids creating new contact if the additional email already exist in the system.

@eileenmcnaughton
Copy link
Contributor

Testing seems appropriate - merging

@eileenmcnaughton eileenmcnaughton merged commit e27a2a3 into civicrm:master Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants