dev/core#297 : fix broken permission 'access my cases and activities'

[monishdeb]

Overview

See https://civicrm.stackexchange.com/questions/25950/problem-with-civicase This regression is caused by CRM-21461 changes.

Before

The permission 'access my cases and activities' was broken.

After

The permission 'access my cases and activities' was fixed.

---

• CRM-21461: Case Dashlet enhancement

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Jenkins re test this please

[eileenmcnaughton]

Test fail seems unrelated @colemanw thoughts?

[eileenmcnaughton]

test this please

[colemanw]

I agree with this fix. I think since this is a regression we should merge it into the RC branch.

[eileenmcnaughton]

@colemanw it looks like it regressed in 4.7.31 - which is long enough ago it's not an automatic for the rc, although it looks pretty safe so I think if you are confident then delivering the fix sooner rather than later makes sense

[colemanw]

Yes I give this fix my official seal of approval.
Actually, there's no :seal: emoji, so I guess I'll have to give it a goat of approval: 🐐

[MegaphoneJon]

Just flagging this as open despite Coleman's goat of approval.

[petednz]

was this in 5.6.1? https://civicrm.stackexchange.com/questions/27218/civicase-access-all-cases-and-activities-issues

[eileenmcnaughton]

was it backported?

[Myrddinwylit]

I don’t know. I checked the lines of code listed in this fix and they are corrected but I am getting the issue below

I have a test site setup using the bitnami VirtualBox build - with civicrm 5.6.1
And I am getting the “too many redirects” on any account that doesn’t have “views all cases” permission checked when I try to access the case dashboard or case management. I can however get to create new case.

[Myrddinwylit]

Ok after some late night playing around it seems the issue is not this fix, but something going wrong with the Civicase Extenstion When I disabled this extension everything worked as it suppose to - going to post this issue there