Don't duplicate activity when filing on case

[mattwire]

Overview

When filing an activity on a case via the "File On Case" link on the activity tab/activity detail view an odd set of parameters is set which results in two separate activities - one which is on the case and one which is not.

Before

• original_id is not set on new activity.
• is_current_revision is not set to FALSE on original activity.

After

• original_id is set on new activity.
• is_current_revision is set to FALSE on original activity.

Technical Details

AFTER is consistent with how case activities are normally handled, ie activity is duplicated, is_current_revision set to false on old activity and original_id set on new activity. UI (searches etc) expect this to be the case.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

@colemanw Is this something you are able to comment on?

[colemanw]

Your code looks correct to me. In general I want to move away from the whole "original id" and "is current revision" gunk because it's a really bad logging system and since that was made for civicase we now have a much better, trigger-based logging system sitewide (not just for case activities). But while we still have that cruft we should at least not allow it to break things.
I haven't had a chance to r-run this but other than that 👍

[colemanw]

I've r-run it now and it seems to be working correctly. I agree that duplicating the activity was not the correct behavior before.