Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[phpunit test only] - Add one additional data integrity check to ensure that after Edit Fin… #12645

Merged
merged 1 commit into from
Aug 12, 2018
Merged

[phpunit test only] - Add one additional data integrity check to ensure that after Edit Fin… #12645

merged 1 commit into from
Aug 12, 2018

Conversation

KarinG
Copy link
Contributor

@KarinG KarinG commented Aug 11, 2018

…ancial Items add up to total_amount at Contribution level.

Overview

This is a small follow up - add/on to: #12629

Before

Test is checking line_items, tax_amount and total_amount all add up [after editing a Membership that has Line Items and Sales Tax associated with it].

After

In addition test is now also checking that the Financial Items add up to total_amount at the contribution level [after editing a Membership that has Line Items and Sales Tax associated with it].

Comments

Bigger picture: one of our clients has been hit with intermittent regressions on the Edit Contribution screen (if the Contribution involves Line Items and Sales Tax) - this will help ensure that what's working currently is locked in.

All tests are passing on my local - over to Jenkins.

…ancial Items add up to total_amount at Contribution level.
@civibot
Copy link

civibot bot commented Aug 11, 2018

(Standard links)

@seamuslee001
Copy link
Contributor

Adding Merge on pass as only affects unit tests and the assumption here is correct IMO

@KarinG
Copy link
Contributor Author

KarinG commented Aug 11, 2018

Hi and Merci - @seamuslee001

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@eileenmcnaughton eileenmcnaughton merged commit b45b705 into civicrm:master Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants