Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL modes to developer tab #12656

Merged
merged 2 commits into from
Aug 14, 2018
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Developer tab shows information for debugging reports, this adds SQL Mode info and fixes a formatting issue

Before

screenshot 2018-08-14 12 16 54

Also nbsp handling is broken since security release
screenshot 2018-08-14 12 16 59

After

screenshot 2018-08-14 12 15 22

screenshot 2018-08-14 12 18 46

Technical Details

The escaping I added is not required but I think it's best practice. Our last round of fixing escaping resulted in spaces being shown as &nbsp - this also fixes that.

Comments

I hit issues because of the STRICT_TRANS_TABLES sql mode imposed on dev sites that was hurting my head. This would have helped me get there quicker

@civibot
Copy link

civibot bot commented Aug 14, 2018

(Standard links)

@colemanw
Copy link
Member

Looks good.
The test fail looks unrelated. retest this please.

@colemanw colemanw merged commit 3422e9b into civicrm:master Aug 14, 2018
@colemanw colemanw deleted the dev_tab branch August 14, 2018 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants