Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21677 - report clean up #12698

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Conversation

yashodha
Copy link
Contributor

@yashodha yashodha commented Aug 20, 2018

Overview

remove redundant piece of code as address display is handled later in https://github.com/civicrm/civicrm-core/blob/master/CRM/Report/Form/Member/Detail.php#L410
Visually no difference between before and after.

Before

b

After

a


@civibot
Copy link

civibot bot commented Aug 20, 2018

(Standard links)

@yashodha
Copy link
Contributor Author

@eileenmcnaughton
I can see similar clean up needs to done for other files as well. I am working on doing this in small chunks.

@eileenmcnaughton
Copy link
Contributor

Thanks @yashodha - I think this is trivial enough & clear enough from the screen shots i can merge based on them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants