Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReportInstance BAO to call post hook after save (instead of calling pre twice). #12722

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fix ReportInstance BAO to call post hook after save

Before

Pre hook called twice

After

Pre hook called once, post hook called once

Technical Details

Also, remove one unused var

Comments

@civibot
Copy link

civibot bot commented Aug 23, 2018

(Standard links)

@monishdeb
Copy link
Member

The patch makes sense. Happy to merge. Test failure is unrelated.

@monishdeb
Copy link
Member

Test failure is unrelated.

@monishdeb monishdeb merged commit 5089971 into civicrm:master Aug 23, 2018
@eileenmcnaughton eileenmcnaughton deleted the report_instance branch August 23, 2018 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants