Towards rationalising settings form & preferences form (partial of 12731) #12732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a trait class & starts to align Settings form with preferences form
Before
The settings form & the preferences form do the same thing but evolved separately. Settings uses metadata, preferences doesn't.
After
This adds a trait that can be shared & the parts of both that use metadata can use the shared section
Technical Details
Over time we should remove both forms in favour of a new clean one based on the trait. I think the trait would be merged into that form.
Note that one issue TBC is how to define 'serialize' on the form. In the DAO we use a string but the generator converts it to a constant. I used just a constant here.
I can break this down into some smaller commits.
Comments
This is a cut down of #12731 for easier review