Setting form - function extraction #12744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
Aug 29, 2018
| $this->addRule('max_attachments', ts('Value should be a positive number'), 'positiveInteger'); | ||
| } | ||
| if ($setting == 'maxFileSize') { | ||
| //temp hack |
There was a problem hiding this comment.
lol - it has survived once again
|
test this please |
1 similar comment
|
test this please |
|
jenkins, test this please |
|
merging as per the tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Extract a function for re-usability
Before
code less maintainable
After
code more maintainable
Technical Details
This is a subset of #12731 intended to keep the function extraction as clean as possible
Comments