Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#346 - Online Pay Now error when used from dashboard checksum… #12745

Merged
merged 2 commits into from
Aug 31, 2018

Conversation

jitendrapurohit
Copy link
Contributor

… link

Overview

Fix checksum URL for paynow link when dashboard is accessed through checksum.

Before

PayNow button URL is not built with cs param when user dashboard is access with checksum. More details at https://lab.civicrm.org/dev/core/issues/346

After

PayNow button URL has cs param which enabled user to complete the payment.

Comments

@magnolia61 Can you pls test this change?


Gitlab Issue - https://lab.civicrm.org/dev/core/issues/346

@civibot
Copy link

civibot bot commented Aug 29, 2018

(Standard links)

@mlutfy
Copy link
Member

mlutfy commented Aug 30, 2018

jenkins, test this please

@jitendrapurohit
Copy link
Contributor Author

Updated the PR to remove inaccessible links/section for checksum users. Display of dashboard looks like -

image

@magnolia61
Copy link
Contributor

magnolia61 commented Aug 31, 2018

Thanks Jitendra. Tested your updated PR and it works fine and as expected.
BTW I used your screenshot to clarify my final remark in this #12319 PR and this take partial payments, user dashboard and checksum access and Pay Now functionality a big step further! Thanks!

@eileenmcnaughton
Copy link
Contributor

Merging based on @magnolia61 testing

@eileenmcnaughton eileenmcnaughton merged commit 2a071b0 into civicrm:master Aug 31, 2018
@magnolia61
Copy link
Contributor

Since this solves a bug resulting in a fatal error for end users in CivCRM 5.4.0 Would it be possible to merge this in the upcoming 5.5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants