Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show ext version status even when directory not writeable #12757

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Aug 31, 2018

Overview

Gives information about extension updates even if the extension directory is not writable.

Before

If the extension directory was not writable, the system check would return early and not check for available updates.

After

System status page shows available updates regardless.

@civibot
Copy link

civibot bot commented Aug 31, 2018

(Standard links)

@colemanw
Copy link
Member Author

@mlutfy could you review this one please? I specifically did it for civicrm.org, where the directory is not writable and we don't get any extension upgrade notices.

@mlutfy
Copy link
Member

mlutfy commented Aug 31, 2018

Thanks @colemanw, I confirm that this fixes the issue. From code review, seems like a reasonable and safe change, with no impact on other users.

@colemanw colemanw merged commit 21b394e into civicrm:master Aug 31, 2018
@colemanw colemanw deleted the ext branch August 31, 2018 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants