-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix REST on WordPress #14186
Fix REST on WordPress #14186
Conversation
(Standard links)
|
@eileenmcnaughton @totten @kcristiano this seems important enough to make an announcement and quick fix release. |
from @kcristiano on mattermost "The PR makes sense to me, but I am not in a position to run a test. Looks like I need to add REST Calls to the testing checklist" |
have also tested this using the E2E Matrix in test.civicrm.org and it fixes some of the tests there and seems to be sensible change to me |
Jenkins re test this please |
@seamuslee001 has this been merged to the rc? |
yes #14189 |
Oooh, nice. So we're now only one test away from a green E2E matrix. :) |
Reported failure is a common false-negative. |
Test fail unrelated merging |
Overview
Civi 5.13.0 broke the REST endpoint on WordPress.
Before
A call like: http://wpmaster.localhost/wp-content/plugins/civicrm/civicrm/extern/rest.php?entity=system&action=check&key=cTJjAAadwbEB2n5w&api_key=54321
results in a 500 error with stack trace:
After
REST endpoint works as expected.
Technical Details
This commit declared an exception when loading the CMS bootstrap by uid as "not implemented". So I implemented it and removed the exception :)