Remove template field if using Mosaico in non shoreditch mode #14927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
This follows our work for Agileware Ref: CIVIMOSAIC-18 - Pengyi will review and provide feedback in the next couple of days. |
ang/crmMailingAB/BlockMailing.html
Outdated
| <option ng-repeat="frm in crmMsgTemplates.getAll() | orderBy:'msg_title'" ng-value="frm.id">{{frm.msg_title}}</option> | ||
| </select> | ||
| <a crm-icon="fa-floppy-o" ng-click="saveTemplate(abtest.mailings.a)" class="crm-hover-button" title="{{ts('Save As')}}"></a> | ||
| <div ng-if="abtest.mailings.a.template_type='traditional'"> |
|
@agileware-pengyi does this require changes from your testing? Comment above suggests you maybe haven't tested but are are more 'discussing' the code? |
|
@eileenmcnaughton @seamuslee001 I tried it. Should be double equal sign here. |
|
ok & @agileware-pengyi - once that is changed is it mergeable? |
|
@eileenmcnaughton yes. Is there anything I should do with that? |
Use double equals instead of single equals
seamuslee001
force-pushed
the
remove_template_field_mosaico
branch
from
1586a84 to
f0327ef
Compare
|
@eileenmcnaughton @agileware-pengyi both updated now as per Pengyi's comment |
|
OK merging as the required change is made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This aims to accomplish something akin to what @agileware-pengyi was aiming to do in veda-consulting-company/uk.co.vedaconsulting.mosaico#322. This does this by only showing the template field if the template_type is traditional
Before
Template field shown even if using Mosaico Template but not using shoreditch
After
Template field hidden in Mosicao
ping @eileenmcnaughton @agileware-pengyi @totten