Unit test for custom date parsing #14988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@eileenmcnaughton the style police officer has logged on https://test.civicrm.org/job/CiviCRM-Core-PR/28214/checkstyleResult/new/ |
Unit test for civicrm#14986 along with some code comments in the test about issues I hit doing what I thought was the right fix - copied here for visibility // @todo I feel like we should work towards this actually parsing $params here - // & dropping formatting but // per civicrm#14986 for now $formatted is parsing // The issue I hit was that when I tried to extend to checking they were correctly imported // I was not actually sure what correct behaviour was for what dates were accepted since // it seems to ignore the latter in favour of the former - which seems wrong.
|
fixed |
|
@seamuslee001 wanna merge this - I think the fix is already merged |
|
Only affects tests, only real checker then is Jenkins and he seems ok with it merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Unit test for #14986
along with some code comments in the test about issues I hit doing what I thought was the right fix
Before
Test not included in fix
After
Test included
Technical Details
Comments about issues I hit copied here for visibility
// @todo I feel like we should work towards this actually parsing $params here -
// & dropping formatting but
// per [REF][Import] add formatted parameter to formatInput #14986 for now $formatted is parsing
// The issue I hit was that when I tried to extend to checking they were correctly imported
// I was not actually sure what correct behaviour was for what dates were accepted since
// it seems to ignore the latter in favour of the former - which seems wrong.
Comments
@lucianov88 FYI