Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ?last? instances of ->free() dev/core#562 #14990

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

These are almost the last places where ->free is to be found. The remaining ones are in the dao
and perhaps out of scope / need more careful investigation

Before

$dao->free() used

After

$dao->free() removed

Technical Details

This is a deprecated method (replaced by $dao->__deconstruct()) which in rare cases causes bugs - we've removed a tonne - I think this might be the last batch

Comments

@seamuslee001 @aydun

These are almost the last places where ->free is to be found. The remaining ones are in the dao
and perhaps out of scope / need more careful investigation
@civibot
Copy link

civibot bot commented Aug 8, 2019

(Standard links)

@civibot civibot bot added the master label Aug 8, 2019
@aydun
Copy link
Contributor

aydun commented Aug 8, 2019

Not tested, but all looks good to me by code review.

@colemanw colemanw merged commit ee9f177 into civicrm:master Aug 8, 2019
@colemanw colemanw deleted the free branch August 8, 2019 12:53
@colemanw
Copy link
Member

colemanw commented Aug 8, 2019

We're free()!

@eileenmcnaughton
Copy link
Contributor Author

lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants