Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Membership fee token fix dev/core/#377 #14992

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Membership fee token fix dev/core/#377 #14992

merged 1 commit into from
Aug 15, 2019

Conversation

sushantpaste
Copy link
Contributor

Fixes for https://lab.civicrm.org/dev/core/issues/377 scheduled reminders.

@civibot
Copy link

civibot bot commented Aug 8, 2019

(Standard links)

@civibot civibot bot added the master label Aug 8, 2019
@eileenmcnaughton
Copy link
Contributor

@mattwire can you check this - looks similar to #12196 which you engaged in discussion (on the first cut)

@yashodha
Copy link
Contributor

@eileenmcnaughton I have tested this and can confirm this works as expected.

@eileenmcnaughton eileenmcnaughton added the merge ready PR will be merged after a few days if there are no objections label Aug 10, 2019
@eileenmcnaughton
Copy link
Contributor

@yashodha given the similarity to the other fix that seems like enough - I've given it the merge-ready flag just to give @mattwire a couple days to comment before it's merged

@yashodha
Copy link
Contributor

@eileenmcnaughton sure

@mattwire
Copy link
Contributor

Merging based on @yashodha testing and comments

@mattwire mattwire merged commit 8008a9f into civicrm:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants