Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1116 - rename local var activityName #15000

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

demeritcowboy
Copy link
Contributor

@demeritcowboy demeritcowboy commented Aug 8, 2019

Overview

This is a continuation of #14999.

Before

Local variable called $activityName is actually label. It isn't used outside this block.

After

Renamed to $activityTypeDisplayLabel.

Technical Details

Comments

@civibot
Copy link

civibot bot commented Aug 8, 2019

(Standard links)

@demeritcowboy demeritcowboy changed the title [Do not merge yet] - dev/core#1116 - rename local var activityName dev/core#1116 - rename local var activityName Aug 13, 2019
@eileenmcnaughton
Copy link
Contributor

Looks good

@eileenmcnaughton eileenmcnaughton merged commit 79eec22 into civicrm:master Aug 13, 2019
@demeritcowboy demeritcowboy deleted the activityName-1116 branch August 14, 2019 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants