dev/core#1116 - refactor/rename activityTypeName #15002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
demeritcowboy
force-pushed
the
activity-type-assignment-1116
branch
from
0d88289 to
45df174
Compare
demeritcowboy
force-pushed
the
activity-type-assignment-1116
branch
from
45df174 to
c6bbfc3
Compare
demeritcowboy
changed the title
|
Looks good |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Continuation of #15032 which brings this back in line with #14972 but with naming changes
Before
Block of code is inside preProcess()
After
Block of code is on its own and has test. No changes were made inside the block that was moved.
Technical Details
Comments
Next steps:
Add in machineName and use it where needed.
Physically add some visual separation between displayName(for contact) and displayLabel(for activityType) so it's not confusing.