dev/core#752 Add cid parameter when loading custom data via backend f…

[seamuslee001]

…orms so that hooks can modifiy based on contact_id being viewed

Overview

This picks up work by @sluc23 from #13191, this adds the cid parameter into customdata urls as per discussion in lab

Before

no cid parameter

After

cid parameter

Technical Details

If the PR introduces noteworthy technical changes, please describe them here. Provide code snippets if necessary

Comments

ping @mattwire @eileenmcnaughton @sluc23

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I feel like $contactID is a more common smarty variable

[seamuslee001]

Probably i guess i was just riffing based on the lab ticket

[sluc23]

looking forwards to have this merged, tx @seamuslee001 !
This will make our life easier when coding custom field's related logic

[eileenmcnaughton]

Putting aside my preference for meaningful variable / parameter names - I'm OK to merge this if you review it @sluc23

[sluc23]

yes, it works.. this hook will set contactID as default value in Activity's custom field (simplest example, then you can use contactID to calculate/search other values) .
Previously some jQuery / $_POST magic was needed..

function testhook_civicrm_buildForm($formName, &$form) {
  if ($formName == 'CRM_Custom_Form_CustomDataByType') {
    if ($form->getAction() == CRM_Core_Action::ADD) {
      foreach ($form->_elements as $index => &$element) {
        if ($element->_attributes['name'] == 'custom_1_-1') {
          // Set Contact ID as default value to a custom field
          $element->_attributes['value'] = $form->getVar('_contactID');
        }
      }
    }
  }
}

[sluc23]

tested!

[eileenmcnaughton]

Merging based on @sluc23 review

@sluc, @seamuslee001 -is there something here that could be documented?

[sluc23]

@eileenmcnaughton do you think is a good idea to add the hook sample i've posted in the hook_civicrm_buildForm documentation?

[sluc23]

only issue, so far, is that only works for Activities, until we spread this for the rest of entities.. I will doing some PRs to extend it for the rest..

[eileenmcnaughton]

@MegaphoneJon any opinions about where / how to document?