[Import] Minor cleanup on membership import #15013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| */ | ||
|
|
||
|
|
||
| require_once 'api/api.php'; |
There was a problem hiding this comment.
@eileenmcnaughton i'm wondering if this was a APIv2 issue or something
There was a problem hiding this comment.
it's certainly historical! That file is always included now - although deprecatedUtils - if used - maybe not
|
Changes look fine to me added MOP |
eileenmcnaughton
force-pushed
the
member_import
branch
from
fd9b306 to
f781f97
Compare
We have a nasty construct (perhaps due to php4 limitations) where the code iterates the _mapperKeys array & sets a class property specifying the key it occupies. We later use this to check it occupies a key. This could be much more readable by just checking the array at the right time. Also I removed an unused private property & a require_once to api.php which is always included
eileenmcnaughton
force-pushed
the
member_import
branch
from
f781f97 to
6467992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Very minor code cleanup
Before
More confusing
After
Less confusing
Technical Details
We have a nasty construct (perhaps due to php4 limitations) where the code iterates the _mapperKeys
array & sets a class property specifying the key it occupies. We later use this to check it occupies a key.
This could be much more readable by just checking the array at the right time.
Also I removed an unused private property & a require_once to api.php which is always included
Comments