[NFC] [Test] dev/core#1098 Add unit test & code comments relating to the slow activity search #15016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vity search The issue is the joining in of component filtering - we should fix this but do it correctly.... We probably need to extend the test to reflect contact ACLs first
|
(Standard links)
|
eileenmcnaughton
changed the title
|
@seamuslee001 this is test-only |
|
Only affects tests and comments just detail the isssue more, tests have passed merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Activity search is brutally slow due to bad joins when adding in ACLS (regardless of permissions). They need to be fixed up to use the preferred methodology - which does not suffer from these bad joins. However, first we need tests - this adds tests & some signposts in the code comments
Before
No test
After
Test
Technical Details
The issue is the joining in of component filtering - we should fix this but do it correctly....
We probably need to extend the test to reflect contact ACLs first
Comments
https://lab.civicrm.org/dev/core/issues/1098