Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [Import] extract saved mapping code to parent class #15017

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor extraction

Before

Less readable

After

More readable

Technical Details

There are multiple forms that should really use this - I will follow up with those changes if this gets merged while I'm still working on import

Comments

@civibot
Copy link

civibot bot commented Aug 12, 2019

(Standard links)

@seamuslee001
Copy link
Contributor

straight forward extraction seems fine to me merging

@seamuslee001 seamuslee001 merged commit a12d53c into civicrm:master Aug 15, 2019
@seamuslee001 seamuslee001 deleted the import_cont branch August 15, 2019 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants