[Ref] [Import] move metadata calculations to a trait #15018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
metadata
branch
2 times, most recently
from
dae8945 to
8812cc7
Compare
Closed
eileenmcnaughton
force-pushed
the
metadata
branch
from
8812cc7 to
b80853f
Compare
|
@seamuslee001 I've updated this to be much closer to a straight extraction for easier review - I've kept the helper functions but removed the calls to them for now |
This metadata needs to be shared between multiple import forms. They do not have a common parent. Curently this is done via calculating once & passing via quickform. However, the formats are convoluted & hard to read. Information that is user generated should be calculated per form - not so much metadata
eileenmcnaughton
force-pushed
the
metadata
branch
from
b80853f to
91b4c63
Compare
| //CRM-5125 | ||
| //supporting import for contact subtypes | ||
| $csType = NULL; | ||
| if ($this->getContactSubType()) { |
There was a problem hiding this comment.
I added functions to avoid enotices here
| $csType = NULL; | ||
| if ($this->getContactSubType()) { | ||
| //custom fields for sub type | ||
| $subTypeFields = CRM_Core_BAO_CustomField::getFieldsForImport($this->getContactSubType()); |
| * | ||
| * @return array | ||
| */ | ||
| protected function getRelationships(): array { |
There was a problem hiding this comment.
And this is just a subset that is also useful elsewhere as it's own fn
|
thanks @seamuslee001 this unblocks me on writing tests for the bug I'm chasing down |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactor to increase shared code
Before
Metadata passed around
After
Metadata retrieved from shared trait
Technical Details
A lot of the complexity of the import classes comes from complex & convoluted handling of metadata.
For reasons now obsolete the metadata is loaded & wrangled into various arrays on the first form and
then passed through storing the form in the session object to later forms (which don't have a shared parent).
We should be passing user form input around but not metadata as that can be retrieved as needed (and
cached for performance). This moves couple of functions out to the metadata and adds a couple of calls to them
reviewer preference
Comments